ci: run tests on PRs #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the checks were only run on branches pushed to the xcp-ng repo, or, when a branch is pushed to a forked repo, against that fork, if it has been configured to run GH actions. This resulted in PRs for branches in a forked repo not to trigger the test actions, and we would miss any regression while the PR is open, and only get hit when the regression hits master. Just activating those actions on pull_request in addition to push would OTOH have them run twice when we push a PR branch, so we restrict the runs on push to only happen when pushing to master. This has a side-effect of non-PR branches not getting the checks run, which we may want to fix in the future. Co-authored-by: Yann Dirson <[email protected]> Signed-off-by: Gaëtan Lehmann <[email protected]>
psafont
approved these changes
Sep 8, 2025
ydirson
approved these changes
Sep 8, 2025
|
oops, mis-click and no confirmation 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the checks were only run on branches pushed to the xcp-ng repo, or, when a branch is pushed to a forked repo, against that fork, if it has been configured to run GH actions.
This resulted in PRs for branches in a forked repo not to trigger the test actions, and we would miss any regression while the PR is open, and only get hit when the regression hits master.
Just activating those actions on pull_request in addition to push would OTOH have them run twice when we push a PR branch, so we restrict the runs on push to only happen when pushing to master. This has a side-effect of non-PR branches not getting the checks run, which we may want to fix in the future.